Use dayPickerProps controlled month before value. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 621 619 -2
Branches 133 132 -1
=====================================
- Hits 621 619 -2
Continue to review full report at Codecov.
|
|
Thanks @kradical I'd review this soon :) Just catching up with the older stuff . |
|
Published as v7.1.0. |
|
awesome! Thank you! |
kimamula
pushed a commit
to kimamula/react-day-picker
that referenced
this pull request
Aug 17, 2022
Use dayPickerProps controlled month before value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @gpbl !
First thank you for your time commitment to this project, it is very useful!
This change is a re-ordering of how the current month is calculated from props. I believe it should use the controlled month from
dayPickerProps.monthbefore it uses the currentvalue.My specific use case is a 4-month calendar using the DayPickerInput date range selection with a from/to input. In my case I want the first month in the 4 month range to show the start of the range but it will default to using the current value. Which on the
toDayPickerInput will possibly be a different month.Otherwise I don't think there is a way to use
DayPickerInputas a controlled component (w/ redux-form for us) and control the month through props.Let me know if there is anything else I can provide to make this easier!