Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toMonth to include the full month #1429

Merged
merged 1 commit into from Apr 7, 2022
Merged

fix: toMonth to include the full month #1429

merged 1 commit into from Apr 7, 2022

Conversation

mputilov
Copy link
Contributor

@mputilov mputilov commented Apr 5, 2022

If toMonth prop passed, we should limit date to the end of the month. Otherwise you cant disable dates in the same month as toMonth because it limits to the first day of month. Example: https://codesandbox.io/s/react-day-picker-base-forked-3b557v

@gpbl
Copy link
Owner

gpbl commented Apr 5, 2022

@mputilov thanks! It makes sense! I would add more tests tho...

@gpbl gpbl changed the title Сhange toDate сalculation, if toMonth prop passed fix: toMonth to include the full month Apr 5, 2022
@gpbl gpbl merged commit 1f95216 into gpbl:master Apr 7, 2022
@gpbl
Copy link
Owner

gpbl commented Apr 7, 2022

Thanks again @mputilov !

gpbl pushed a commit that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants