Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): use div instead of button for grid cells #2089

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

gpbl
Copy link
Owner

@gpbl gpbl commented Apr 17, 2024

Fixes #1688

Description

WIP.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Signed-off-by: gpbl <io@gpbl.dev>
Signed-off-by: gpbl <io@gpbl.dev>

# Conflicts:
#	src/components/Day/Day.test.tsx
#	src/components/Day/Day.tsx
#	src/hooks/useDayEventHandlers/useDayEventHandlers.test.tsx
#	src/hooks/useDayEventHandlers/useDayEventHandlers.tsx
#	src/hooks/useDayRender/useDayRender.test.tsx
#	src/hooks/useDayRender/useDayRender.tsx
Signed-off-by: gpbl <io@gpbl.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: gridcell ARIA role incorrectly added to Day button element
1 participant