-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): deprecations and updated type names #2138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm updating the types to make them more consistent to the next version of react-day-picker.
Breaking: Formatters
Formatters were not meant to return a
ReactNode
but astring
. For React Nodes, a custom component should be used instead.Breaking: Renamed Previous/Next Buttons label
These will require a test update.
Deprecated Types
The following types have been renamed. The old names have been deprecated in
components/deprecated.ts
and shouldn't be used anymore.DaySelectionMode
Mode
DayPickerDefaultProps
PropsDefault
DayPickerSingleProps
PropsSingle
DayPickerMultipleProps
PropsMulti
DayPickerRangeProps
PropsRange
WeekNumber
WeekNumberRowHeader
Row
WeekRow
HeadRow
WeekdaysRow
Caption
MonthCaption
Month
MonthGrid
Root
Calendar
RootProviderProps
ContextProvidersProps
RootProvider
ContextProviders
Custom Components
Instead of adding manually the custom components, they are now exported in
custom-components.ts
. The type is now defined using the exports.CustomComponents
: define type using exports (2bad3c3)