-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide overlay on overlayblur #871
Hide overlay on overlayblur #871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 659 660 +1
Branches 146 146
=====================================
+ Hits 659 660 +1
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 659 660 +1
Branches 146 146
=====================================
+ Hits 659 660 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 15 15
Lines 659 660 +1
Branches 146 146
=====================================
+ Hits 659 660 +1
Continue to review full report at Codecov.
|
Tested this a bit more. It solves one particular issue, but creates a bunch more issues with the standard React-Day-Input. Will revisit this once I have more time, but please let me know if a fix comes to mind. |
I'm not sure how to patch the bug while maintaining standard behavior. |
@matthova I had this same issue a while ago, stumbled across this while looking for a way to keep the overlay always open. I ended up doing this to get around it, not ideal but might help
|
This PR addresses the bug described in issue #819.
Old behavior: When using a custom overlay, after clicking on anything in the overlay, then clicking away, the overlay does not close. Once the overlay has been focused, the only way to make the overlay close is to click on the input and then click away.
New behavior: After clicking on anything in the overlay, then clicking away, the overlay will close.
Note: With this PR - If the user clicks on the input field, after clicking on something inside of the overlay, the overlay will momentarily close and then reopen. This is not ideal, but it is better than the current behavior. If there is a preferred way to avoid calling
setState
when clicking on the input field, let's do that instead 👍.🚀 Amazing library 🚀 I hope this PR helps