Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update type export to allow importing DateUtils methods #904

Merged
merged 1 commit into from
Aug 3, 2019
Merged

fix(types): update type export to allow importing DateUtils methods #904

merged 1 commit into from
Aug 3, 2019

Conversation

Nibblesh
Copy link

@Nibblesh Nibblesh commented May 13, 2019

πŸ‘‹πŸ½ Thanks for opening a pull request!

Issues: #865, #887, #896

Explicitly list module declaration for exported util functions

  • Please explain clearly your changes. If they involve a lot of code, let discuss them first in on our gitter room:
    https://gitter.im/gpbl/react-day-picker
  • πŸ™πŸ½ Please DO NOT build files or update the docs in your pull request – as this may cause git conflicts. Thanks!

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #904   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         659    659           
  Branches      146    146           
=====================================
  Hits          659    659

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 421af9f...b194658. Read the comment docs.

@veddermatic
Copy link

Any ideas when this will get merged / published?

@gpbl gpbl merged commit c15e2bf into gpbl:master Aug 3, 2019
@gpbl
Copy link
Owner

gpbl commented Aug 3, 2019

Here we go, sorry – i've been too busy lately.

@milesj
Copy link

milesj commented Aug 7, 2019

@Nibblesh @gpbl This doesn't seem to work on TS v3.5.

node_modules/react-day-picker/types/index.d.ts:10:35 - error TS2694: Namespace '"node_modules/react-day-picker/types/utils"' has no exported member 'DateUtils'.

10 export const DateUtils: UtilTypes.DateUtils;
                                     ~~~~~~~~~

node_modules/react-day-picker/types/index.d.ts:11:37 - error TS2694: Namespace '"node_modules/react-day-picker/types/utils"' has no exported member 'LocaleUtils'.

11 export const LocaleUtils: UtilTypes.LocaleUtils;
                                       ~~~~~~~~~~~

node_modules/react-day-picker/types/index.d.ts:12:40 - error TS2694: Namespace '"node_modules/react-day-picker/types/utils"' has no exported member 'ModifiersUtils'.

12 export const ModifiersUtils: UtilTypes.ModifiersUtils;
                                          ~~~~~~~~~~~~~~

@rhfung
Copy link

rhfung commented Aug 12, 2019

Same here, doesn't seem to work on TS v3.5

@Nibblesh
Copy link
Author

Was going to give this a try today but it seems to have been fixed:
#916

@Nibblesh Nibblesh deleted the feature/util-types branch August 23, 2019 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants