raw is broken, value seems pre-encoded

[xpusostomos]

I wanted to make a field template that has pre-encoded HTML:
_fields/contract/contractTerms/displayWidget.gsp:

${raw(value)}

value is expected to contain HTML. However, raw() doesn't work inside a template.

I put this in to see what happens:
${raw(value[0])}

And for HTML that starts with a tag... <ol> it outputs & confirming that it's the start of an encoded string of <

I find it quite bizarre that it encodes the value before it even gets to the template, because this precludes a whole range of processing that one might be inclined to do in the template. Certainly I've never seen this behaviour in any other grails templates where raw() works fine.

As far as I can see, the problem exists in FormFieldsTagLib.groovy line 448:

		if (value instanceof String && encoding) {
			value = codecLookup.lookupEncoder(encoding).encode(value)
		}

Straight off the bat, special casing String at this level looks dodgy. The code at this level shouldn't be making any decisions about the meaning of the String and how it's going to be output. The String could be any number of of special things that should be passed through unmolested.

I might add, that the output is actually getting double encoded. I proved this by re-rawing the value..

${value.replaceAll('&lt;', '<').replaceAll('&gt;', '>'))
This still doesn't get output as raw HTML. I have to do...

${raw(value.replaceAll('&lt;', '<').replaceAll('&gt;', '>'))}
That indicates that the already-html-encoded value is getting re-encoded a 2nd time.
`