Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks like MakeDefault doesn't do anything? #36

Closed
Jaykul opened this issue Sep 18, 2019 · 3 comments
Closed

Looks like MakeDefault doesn't do anything? #36

Jaykul opened this issue Sep 18, 2019 · 3 comments

Comments

@Jaykul
Copy link

Jaykul commented Sep 18, 2019

I can't just try the module because of the path issue in #35 ... but it looks like the MakeDefault switch in Set-MSTerminalProfile doesn't do anything?

https://github.com/gpduck/MSTerminalSettings/blob/preview/src/ExportedFunctions/Set-MSTerminalProfile.ps1
@gpduck
Copy link
Owner

gpduck commented Sep 18, 2019

Yeah looks like it.

There's a build on appveyor for the latest PR. I need to get it merged and released for real...

@jhoneill
Copy link

Ha, I've just been plating with this and put my own code in for it :-) Maybe I don't need to send a PR with that, and just wait for the update.

@gpduck gpduck closed this as completed in 7ad0eca Sep 19, 2019
@gpduck
Copy link
Owner

gpduck commented Sep 19, 2019

This is fixed in the latest preview release on the gallery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jaykul @gpduck @jhoneill