Rietveld's "too large to download" patches. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define api_url, rename riet_json -> riet_issue_json, in preparation to extending the patch fetching code.
Avoid the 404 error on patchsets that are "too large". Since patch download links are available for individual files, we donwload them one by one and concatenate them to obtain the complete patch. Workaround for Rietveld issue 196: http://code.google.com/p/rietveld/issues/detail?id=196
jrioux
added a commit
that referenced
this pull request
Aug 30, 2013
Rietveld's "too large to download" patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to download "too large to download" patchsets.
Avoid the 404 error on patchsets that are "too large". Since patch download links are available for individual files, we download them one by one and concatenate them to obtain the complete patch.
Workaround for Rietveld issue 196:
http://code.google.com/p/rietveld/issues/detail?id=196
Test bed: issue 3502
http://code.google.com/p/lilypond/issues/detail?id=3502