Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: executors are not awaited in nx-prisma #818

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

femshima
Copy link
Contributor

@femshima femshima commented Jun 19, 2023

Fixes #815

Command executor has not been awaited since #788, and it caused a bug where nx-prisma's executors immediately exits without running the command.

This PR adds await for seed and other commands (except for synchrounously executed command like migrate and reset) to fix this bug.

@femshima femshima requested a review from gperdomor as a code owner June 19, 2023 11:54
@gperdomor gperdomor merged commit a41c9f9 into gperdomor:main Jun 21, 2023
6 checks passed
@nx-cloud
Copy link

nx-cloud bot commented Jun 21, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0136a5d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@femshima femshima deleted the fix-prisma-immediate-exit branch June 21, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nx-prisma] Running any of the executors immediately exits as success, but doesn't run the underlying command
2 participants