fix cmake pthread complile #1473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for the patch. But can you please elaborate what is the issue exactly that you're fixing here. What doesn't work without this patch ? |
Description: Debian GNU/Linux 9.8 (stretch) I have encountered this problem |
|
Thanks. it is clear now. But adding -lpthread is not the right fix. Some OSes don't have -lpthread. So I'll see what might be wrong. P.S. Also for the later, please, consider learning how to quote regular text rather then posting screenshoots. Not as usable on mobile. |
alk
added a commit
to alk/gperftools
that referenced
this pull request
Jan 3, 2024
|
See my commit linked above. Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need to add a dependency on pthread here.