Added a few more API methods #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, dren-dk, |
|
Sounds good, folks! Since we've got to wait on Net::HTTP::Spore can someone ping me when that gets squared away? Also, I'm happy to give out comaint bits or transfer the module if anyone is interested! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added a couple of new API methods: get_projects, get_filter, search and add_comment
Notice that for search to work (because the jql parameter is bound to contain = chars) we need a fixed version of Net::HTTP::SPORE, because the current version fails to escape the parameters correctly, it ought to be possible to work around the bug by escaping the parameters, but that would break once Net::HTTP::SPORE gets fixed.
I've sent the Net::HTTP::SPORE maintainer a pull request with this fix:
dren-dk/net-http-spore@c560233