Skip to content

Commit

Permalink
decoce mirrorlock up state for EOS, as mirrorstatus for config. #913
Browse files Browse the repository at this point in the history
  • Loading branch information
msmeissn committed Jun 18, 2023
1 parent 17a362e commit 50338bd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions camlibs/ptp2/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -10610,6 +10610,7 @@ static struct submenu camera_status_menu[] = {
{ N_("Battery Level"), "batterylevel", PTP_DPC_CANON_EOS_BatteryPower, PTP_VENDOR_CANON, PTP_DTC_UINT16, _get_Canon_EOS_BatteryLevel, _put_None },
{ N_("Battery Level"), "batterylevel", PTP_DPC_SONY_BatteryLevel, PTP_VENDOR_SONY, PTP_DTC_INT8, _get_SONY_BatteryLevel, _put_None },
{ N_("Mirror Up Status"), "mirrorupstatus", PTP_DPC_NIKON_MirrorUpStatus, PTP_VENDOR_NIKON, PTP_DTC_UINT8, _get_Nikon_OnOff_UINT8, _put_None },
{ N_("Mirror Up Status"), "mirrorupstatus", PTP_DPC_CANON_EOS_MirrorLockupState, PTP_VENDOR_CANON, PTP_DTC_UINT32, _get_INT, _put_None },

This comment has been minimized.

Copy link
@anjok

anjok Jun 18, 2023

This isn't the Mirror Up Status, but rather the Mirror Lock Status

This comment has been minimized.

Copy link
@anjok

anjok Jun 19, 2023

Here's the candidate list for this "is the mirror up" setting:

6399,4: {PTP_DPC_CANON_EOS_MirrorUpSetting,"EOS_MirrorUpSetting"},
6518,4: {PTP_DPC_CANON_EOS_MirrorDownStatus,"EOS_MirrorDownStatus"},
6520,4: {PTP_DPC_CANON_EOS_MirrorLockupState,"EOS_MirrorLockupState"},

For both EOS_MirrorLockupState and EOS_MirrorUpSetting I got "01" values when I enable Mirror lock in the UI and do --get-config and "00" when I disable it. So I'm not sure which one it is, but "Mirror Up Status" is not PTP_DPC_CANON_EOS_MirrorLockupState.

{ N_("Mirror Up Shooting Count"),"mirrorupshootingcount", PTP_DPC_NIKON_MirrorUpReleaseShootingCount, PTP_VENDOR_NIKON, PTP_DTC_UINT8, _get_INT, _put_None },
{ N_("Continuous Shooting Count"),"continousshootingcount", PTP_DPC_NIKON_ContinousShootingCount, PTP_VENDOR_NIKON, PTP_DTC_UINT8,_get_INT, _put_None },
{ N_("Camera Orientation"), "orientation", PTP_DPC_NIKON_CameraOrientation, PTP_VENDOR_NIKON, PTP_DTC_UINT8, _get_Nikon_CameraOrientation, _put_None },
Expand Down
1 change: 1 addition & 0 deletions camlibs/ptp2/ptp-pack.c
Original file line number Diff line number Diff line change
Expand Up @@ -2317,6 +2317,7 @@ ptp_unpack_CANON_changes (PTPParams *params, unsigned char* data, unsigned int d
case PTP_DPC_CANON_EOS_OneShotRawOn:
case PTP_DPC_CANON_EOS_FlashChargingState:
case PTP_DPC_CANON_EOS_MovieServoAF:
case PTP_DPC_CANON_EOS_MirrorLockupState:
dpd->DataType = PTP_DTC_UINT32;
break;
/* enumeration for AEM is never provided, but is available to set */
Expand Down

0 comments on commit 50338bd

Please sign in to comment.