Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'X-Goog-Upload-Name' header for 'X-Goog-Upload-File-Name' header #117

Merged
merged 3 commits into from Oct 24, 2023

Conversation

pacoorozco
Copy link
Member

@pacoorozco pacoorozco commented Oct 24, 2023

Signed-off-by: pacoorozco paco@pacoorozco.info

What issue type does this pull request address? (keep at least one, remove the others)
/kind bug

What is this pull request for? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #116, closes #115
enable resolution of gphotosuploader/gphotos-uploader-cli#398

Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
No

Does this pull request add new dependencies?
No

Signed-off-by: pacoorozco <paco@pacoorozco.info>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #117 (1d59ca8) into main (720a571) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files           9        9           
  Lines         583      583           
=======================================
  Hits          492      492           
  Misses         64       64           
  Partials       27       27           
Files Coverage Δ
uploader/uploader_resumable.go 66.18% <100.00%> (ø)
uploader/uploader_simple.go 63.63% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
@pacoorozco pacoorozco merged commit 2c509dc into main Oct 24, 2023
12 checks passed
@pacoorozco pacoorozco deleted the issue-116 branch October 24, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploads are showing the date of the upload as filename
1 participant