-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support device detection under aarch64 #688
Comments
What distro are you using? Where did you get the image from? |
I am using Arch Linux ARM (aarch64 version) and built the package for the Python library provided by this repository myself. I've been using the following build script: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=python-gpiozero Actually I've used a slightly adjusted version to get the latest commit available in this repository (in the hope the support has already been added since the last release). |
Great. No issue with getting this fixed - but I'm a little busy right now, so if you want to try to patch it yourself, feel free to send a PR. |
Under aarch64, /proc/cpuinfo does not contain the revision number. This adds a fallback to /proc/device-tree so the revision can be detected under 64-bit systems as well. See gpiozero#688
Ping. Any update? |
Not from my side. So the tests are still missing but one can locally apply the first commit from my PR in the mean time. |
Note that RPi.GPIO and pigpio (two of the pin libraries supported by GpioZero) don't appear to support aarch64 either yet... |
Just for reference: Fixed by #689 |
I've fixed RPi.GPIO for aarch64 now (please test and confirm). |
Under aarch64,
/proc/cpuinfo
does not contain the revision number leading to the error "unable to locate Pi revision in /proc/cpuinfo".This is not likely to change. So I suppose it would be the best to add a fallback to
/proc/device-tree
.I tested the following C implementation and it seems to work: https://github.com/jgarff/rpi_ws281x/pull/316/files#diff-6ee9c21b70f61e8effb715dd4df0ab53R330
So to solve this issue, one would simply need to port it to Python and use it as fallback before raising the exception linked above.
I'm wondering why this hasn't been implemented yet as it seems to be an easy task. But if you agree to have device detection work under aarch64 in the way I suggested, I would go ahead and create PR.
The text was updated successfully, but these errors were encountered: