Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in the 'run from git' instructions. #42

Merged
merged 2 commits into from Nov 18, 2022

Conversation

auouymous
Copy link
Member

No description provided.

## Instructions

git clone https://github.com/gpodder/gpodder.git
cd gpodder
python3 tools/localdepends.py # To install dependencies
python3 tools/localdepends.py # To install dependencies not listed above

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools/localdepends.py script installs podcastparser and mygpoclient from tarballs in PyPI to directories under src/. Since these both can be installed with pip it would be perhaps better to change this line to a pip command which installs modules from requirements.txt: pip -r tools/requirements.txt. This installs some additional, optional modules as well though.

If we recommend pip to install dependencies, then the localdepends.py script could be also removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it's probably a good time to retire localdepends.py. Back when it started, pip wasn't so widespread and mature as it is nowadays.

I recommend using:

python3 -m pip install -r requirements.txt

Add --user if the user can't write to system directories.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the commands and also removed localdepends.py from the user manual.

auouymous added a commit to auouymous/gpodder that referenced this pull request Nov 8, 2022
As of gpodder/gpodder.github.io#42, it is now
recommended to use pip to install tools/requirements.txt.
@auouymous auouymous merged commit fb6216d into gpodder:master Nov 18, 2022
@auouymous auouymous deleted the update-git-deps branch November 18, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants