Show covers directly after adding feeds (bug 1987) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a new podcast feed a cover will get downloaded in the background. Once it is finished gPodder.cover_download_finished() calls PodcastListModel.add_cover_by_channel(), however by then a placeholder cover will already be in the cache and the new cover will not be shown. cover_download_finished() is the only caller of add_cover_by_channel(), so generally clearing the cache when adding a new cover should be fine.
|
Great, I had this issue also a few times, but never bothered to investigate. Good work! |
thp
added a commit
that referenced
this pull request
Feb 15, 2015
Show covers directly after adding feeds (bug 1987)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new podcast feed a cover will get downloaded in the
background. Once it is finished gPodder.cover_download_finished() calls
PodcastListModel.add_cover_by_channel(), however by then a placeholder
cover will already be in the cache and the new cover will not be shown.
cover_download_finished() is the only caller of add_cover_by_channel(),
so generally clearing the cache when adding a new cover should be fine.
I reported this as https://bugs.gpodder.org/show_bug.cgi?id=1987, earlier.