Add setting to disable find-as-you-type. #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new setting defaults to enabled to preserve the current behavior of opening search fields in channel and episode lists when the user begins typing. Disabling the feature ignores the keypresses and requires ctrl-f or ctrl-shift-f to open or focus the search field.
|
How about also adding '/' as a shortcut for searching where the current focus is (either channels or episodes) when type-to-search is disabled? I'm probably going to add this kind of feature to the adaptive branch (vim-keys FTW) and it would be nice to be compatible. |
|
See comments in #1256. The goal is to have actions the user can bind to keys. This patch is just to disable find-as-you-type until one of us implements the rest. It would even be acceptable to hard-code the keys and add key binding support later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new setting defaults to enabled to preserve the current behavior of opening search fields in channel and episode lists when the user begins typing. Disabling the feature ignores the keypresses and requires ctrl-f or ctrl-shift-f to open or focus the search field.