Fix hang when resuming thousands of episodes. #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! |
|
@elelay Ya, I've had a note to replace the deprecated GObject.timeout_add and GObject.idle_add calls for a while now, and will get to it after this is fixed, which it sadly isn't yet. |
auouymous
force-pushed
the
fix-hang-when-resuming-thousands-of-episodes
branch
from
988b8f0
to
8ffe78a
Compare
When the number of episodes causes update_downloads_list() to exceed 1.5 seconds, the idle_add callback will never be called and cause gpodder to hang. Fixes gpodder#1311.
auouymous
force-pushed
the
fix-hang-when-resuming-thousands-of-episodes
branch
from
8ffe78a
to
f20f1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of episodes causes update_downloads_list() to exceed 1.5 seconds, the idle_add callback will never be called and cause gpodder to hang.
Fixes #1311.