Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural form of translation string. #1553

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

neodyne
Copy link
Contributor

@neodyne neodyne commented Sep 7, 2023

Noticed a translation string without a plural form while working on bringing the Slovak translation of gPodder up to date.
I guess Renamed 1 downloaded episodes is passable in English, but it stands out in other languages, especially those with multiple plural forms (like Slovak):

Renamed 1 episode    -> Premenovaná 1 epizóda
Renamed 2-4 episodes -> Premenované 2 epizódy
Renamed 5+ episodes  -> Premenovaných 5 epizód

make messages will need to be rerun as well, to update messages.pot and individual translations.

@elelay elelay merged commit 7130438 into gpodder:master Sep 16, 2023
6 checks passed
@elelay
Copy link
Member

elelay commented Sep 16, 2023

merged, thanks!

@elelay
Copy link
Member

elelay commented Sep 16, 2023

By the way, do you have a strong opinion on #1551? If so I would like to ear from you :-)

@neodyne neodyne deleted the rename-add-plural branch September 19, 2023 12:30
@neodyne
Copy link
Contributor Author

neodyne commented Sep 19, 2023

By the way, do you have a strong opinion on #1551? If so I would like to [h]ear from you :-)

@elelay Not necessarily a strong opinion, but I agree with "--:--", it gets the point across and doesn't have translation issues. Filesize / transfer speed should be translated (so Ko/s in French?, КБ/с in Russian etc.).

By the way, the Slovak translation in #1555 should be ready to be merged; I also submitted #1556, if you'd take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants