Fix to only include unplayed episodes in playlist

[jnwickremasinghe]

Bug 1789 - Played episodes are still being included in playlists even if 'only sync unplayed' is checked. This patch fixes this problem.

[thp]

Thanks for your fix. For future commits, it would be helpful to structure the first line of the commit message like this:

<component>: <description> (bug <id>)

In your case:

Device sync: Only include unplayed episodes in playlist (bug 1789)

This will make things much easier for me at release time when compiling the release announcement, and will make sure that nothing slips through. Also, in case somebody uses git bisect to find a bug, having a pointer to the bug in question will usually also help a lot.

[jnwickremasinghe]

Ok, I'll make sure to do that.

By the way, i'm still working on the ipod sync feature. I'm making some progress, and plan on posting on the blog about it soon...
Joseph
--- On Tue, 4/23/13, Thomas Perl notifications@github.com wrote:

From: Thomas Perl notifications@github.com
Subject: Re: [gpodder] Fix to only include unplayed episodes in playlist (#88)
To: "gpodder/gpodder" gpodder@noreply.github.com
Cc: "Joseph W." jnwickremasinghe@yahoo.com
Date: Tuesday, April 23, 2013, 12:44 PM

Thanks for your fix. For future commits, it would be helpful to structure the first line of the commit message like this:

: (bug )

In your case:

Device sync: Only include unplayed episodes in playlist (bug 1789)

This will make things much easier for me at release time when compiling the release announcement, and will make sure that nothing slips through. Also, in case somebody uses git bisect to find a bug, having a pointer to the bug in question will usually also help a lot.

—
Reply to this email directly or view it on GitHub.