Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option confusion #16

Closed
stefanpenner opened this issue Mar 26, 2015 · 7 comments
Closed

option confusion #16

stefanpenner opened this issue Mar 26, 2015 · 7 comments

Comments

@stefanpenner
Copy link
Contributor

https://github.com/gdub22/ember-cli-less/blob/master/index.js#L38 these options are for configuring the client-side app not the build tool

@gpoitch
Copy link
Owner

gpoitch commented Mar 26, 2015

@stefanpenner ya, shouldn't be there. @azirbel any reason you added that in your PR? #14

@azirbel
Copy link
Contributor

azirbel commented Mar 26, 2015

not a good reason; I copied it from https://github.com/aexmachina/ember-cli-sass/blob/master/index.js#L42. Sorry =/

@gpoitch
Copy link
Owner

gpoitch commented Mar 26, 2015

@azirbel no worries, easy to remove. @stefanpenner you may want to open an issue over there too if this is a concern.

@simonexmachina
Copy link

Hmmn, interesting. I received a PR that implemented the required changes for addons that were introduced in ember-cli@0.2.0. This PR also moved the configuration out of the Brocfile based on discussion with @rwjblue: http://cl.ly/image/1T3L3l0d1B1w. I thought it was strange but after some investigation decided that I'd follow Robert's instruction.

Can I get clarification of where the config for this should live? Is it "build tool = Brocfile, client app = config/environment.js"?

@stefanpenner
Copy link
Contributor Author

@aexmachina yes. Although the build-tool config is shitty right now. We plan to improve.

@simonexmachina
Copy link

Okay, I'll move it back to the Brocfile then. Probably should have sought clarification from @rwjblue in the first place.

@gpoitch
Copy link
Owner

gpoitch commented Apr 7, 2015

Resolved by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants