-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option confusion #16
Comments
@stefanpenner ya, shouldn't be there. @azirbel any reason you added that in your PR? #14 |
not a good reason; I copied it from https://github.com/aexmachina/ember-cli-sass/blob/master/index.js#L42. Sorry =/ |
@azirbel no worries, easy to remove. @stefanpenner you may want to open an issue over there too if this is a concern. |
Hmmn, interesting. I received a PR that implemented the required changes for addons that were introduced in ember-cli@0.2.0. This PR also moved the configuration out of the Brocfile based on discussion with @rwjblue: http://cl.ly/image/1T3L3l0d1B1w. I thought it was strange but after some investigation decided that I'd follow Robert's instruction. Can I get clarification of where the config for this should live? Is it "build tool = Brocfile, client app = config/environment.js"? |
@aexmachina yes. Although the build-tool config is shitty right now. We plan to improve. |
Okay, I'll move it back to the Brocfile then. Probably should have sought clarification from @rwjblue in the first place. |
Resolved by #21 |
https://github.com/gdub22/ember-cli-less/blob/master/index.js#L38 these options are for configuring the client-side app not the build tool
The text was updated successfully, but these errors were encountered: