Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paid edition's of the database aren't allowed as "edition" value #60

Closed
aalwash opened this issue Sep 10, 2020 · 2 comments · Fixed by #62
Closed

Paid edition's of the database aren't allowed as "edition" value #60

aalwash opened this issue Sep 10, 2020 · 2 comments · Fixed by #62
Assignees
@peter-gribanov
Labels
bug

Comments

@aalwash
Copy link
Contributor

aalwash commented Sep 10, 2020 •
edited
Loading

Thanks to this PR #56 you can't choose a paid edition

So please add the following possible values:

  • GeoIP2-City
  • GeoIP2-Country

PS: Work around for now:

  default_database: 'default'
  databases:
    default:
      edition: 'GeoLite2-City'
      license: '<fill your license>' 
      # Paid version:
      url: 'https://download.maxmind.com/app/geoip_download?edition_id=GeoIP2-City&suffix=tar.gz&license_key=<fill your license>'```
@aalwash aalwash changed the title Paid edition's aren't possible to select Paid edition's of the database aren't allowed as "edition" value Sep 10, 2020
squeezelytech pushed a commit to squeezely/geoip2 that referenced this issue Sep 10, 2020
@aalwash
gpslab#60 Allow paid edition databases
4cb70da
@aalwash aalwash mentioned this issue Sep 10, 2020
Merged
jspeedz added a commit to squeezely/geoip2 that referenced this issue Sep 10, 2020
@jspeedz
gpslab#60 Allow paid edition databases: add more edition_ids
f7a7575
@peter-gribanov peter-gribanov self-assigned this Sep 10, 2020
@peter-gribanov peter-gribanov mentioned this issue Sep 10, 2020
Merged
@peter-gribanov
Copy link
Member

Thank you for your report. Is your problem solved?

@aalwash
Copy link
Contributor Author

aalwash commented Sep 16, 2020

Yes, thanks
It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-gribanov peter-gribanov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add paid editions of the database to a "edition" configuration option peter-gribanov/geoip2
2 participants
@peter-gribanov @aalwash