Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not use ArrayNodeDefinition::cannotBeEmpty() #32

Merged
merged 1 commit into from Jan 29, 2020
Merged

Not use ArrayNodeDefinition::cannotBeEmpty() #32

merged 1 commit into from Jan 29, 2020

Conversation

peter-gribanov
Copy link
Member

Fix deprecation error

Using Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition::cannotBeEmpty() at path gpslab_geoip.databases..locales has no effect, con
sider requiresAtLeastOneElement() instead. In 4.0 both methods will behave the same.

@peter-gribanov peter-gribanov self-assigned this Jan 29, 2020
@peter-gribanov peter-gribanov added this to the Release 2.0.0 milestone Jan 29, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.628% when pulling 0b40dfd on peter-gribanov:empty_locales into 2b36033 on gpslab:2.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.628% when pulling 0b40dfd on peter-gribanov:empty_locales into 2b36033 on gpslab:2.0.

@peter-gribanov peter-gribanov merged commit 1680cab into gpslab:2.0 Jan 29, 2020
@peter-gribanov peter-gribanov deleted the empty_locales branch January 29, 2020 14:00
@peter-gribanov peter-gribanov mentioned this pull request Feb 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peter-gribanov peter-gribanov

Labels
bug
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter-gribanov @coveralls