Merge pull request #21 from gpslab/requiresSQLCommentHint

Requires SQL comment hint for DBAL types
gpslab · Apr 15, 2020 · 2f1abf5 · 2f1abf5
2 parents e697f97 + b3cb29b
commit 2f1abf5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Persistence/Doctrine/DBAL/Types/BaseType.php b/src/Persistence/Doctrine/DBAL/Types/BaseType.php
@@ -62,6 +62,14 @@ public function getName()
         return array_pop($names);
     }
 
+    /**
+     * @return bool
+     */
+    public function requiresSQLCommentHint(AbstractPlatform $platform)
+    {
+        return true;
+    }
+
     /**
      * @return string
      */

diff --git a/tests/Persistence/Doctrine/DBAL/Types/IntervalTypeTest.php b/tests/Persistence/Doctrine/DBAL/Types/IntervalTypeTest.php
@@ -223,4 +223,14 @@ private function getInterval($class, $interval)
     {
         return call_user_func([$class, 'fromString'], $interval);
     }
+
+    /**
+     * @dataProvider getTypes
+     *
+     * @param BaseType $type
+     */
+    public function testRequiresSQLCommentHint(BaseType $type)
+    {
+        $this->assertTrue($type->requiresSQLCommentHint($this->platform));
+    }
 }