-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image prompts - Entrypoint prompt - additional CLI argument #1077
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 84.45% 84.05% -0.41%
==========================================
Files 26 27 +1
Lines 1396 1486 +90
==========================================
+ Hits 1179 1249 +70
- Misses 217 237 +20 ☔ View full report in Codecov by Sentry. |
# combined_dict = {**files_dict, **entrypoint} | ||
# files_dict = FilesDict(combined_dict) | ||
|
||
# entrypoint = gen_entrypoint( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure we want commented code here? its always in the git history if we want to bring it back later - or are we expecting this to be commented in and out regularly
prompt_file : str | ||
Relative path to a text file containing a prompt. | ||
entrypoint_prompt_file: str | ||
Relative path to a text file containing a file that specifies requirements for you entrypoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
messages = ai.next(messages, step_name=curr_fn()) | ||
edit_refinements += 1 | ||
files_dict = salvage_correct_hunks(messages, files_dict, problems) | ||
# if len(problems) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same point about code comments
OK @ATheorell Ive added some docs - and ive tested that its all working. looks good to me now. Im happy to merge - will leave the final review and merge to you? |
This is a continuation of PR #1066, which in addition to providing command line arguments to provide a custom prompt file and a directory with images, also allows the user to pass a prompt to generate entry point.
I suggest that we continue with #1066 here @TheoMcCabe
Unfortunately, the PR has drifted a bit and now contains substantial changes