Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image prompts - Entrypoint prompt - additional CLI argument #1077

Merged
merged 52 commits into from
Mar 20, 2024

Conversation

ATheorell
Copy link
Collaborator

This is a continuation of PR #1066, which in addition to providing command line arguments to provide a custom prompt file and a directory with images, also allows the user to pass a prompt to generate entry point.
I suggest that we continue with #1066 here @TheoMcCabe

Unfortunately, the PR has drifted a bit and now contains substantial changes

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 85.36585% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.05%. Comparing base (7873779) to head (eb057ee).

Files Patch % Lines
gpt_engineer/applications/cli/main.py 75.00% 9 Missing ⚠️
gpt_engineer/core/ai.py 77.77% 6 Missing ⚠️
gpt_engineer/tools/custom_steps.py 70.58% 5 Missing ⚠️
gpt_engineer/core/prompt.py 80.00% 3 Missing ⚠️
gpt_engineer/core/default/disk_memory.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   84.45%   84.05%   -0.41%     
==========================================
  Files          26       27       +1     
  Lines        1396     1486      +90     
==========================================
+ Hits         1179     1249      +70     
- Misses        217      237      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# combined_dict = {**files_dict, **entrypoint}
# files_dict = FilesDict(combined_dict)

# entrypoint = gen_entrypoint(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure we want commented code here? its always in the git history if we want to bring it back later - or are we expecting this to be commented in and out regularly

prompt_file : str
Relative path to a text file containing a prompt.
entrypoint_prompt_file: str
Relative path to a text file containing a file that specifies requirements for you entrypoint.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

messages = ai.next(messages, step_name=curr_fn())
edit_refinements += 1
files_dict = salvage_correct_hunks(messages, files_dict, problems)
# if len(problems) > 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same point about code comments

tests/caching_ai.py Outdated Show resolved Hide resolved
@TheoMcCabe
Copy link
Collaborator

OK @ATheorell Ive added some docs - and ive tested that its all working. looks good to me now. Im happy to merge - will leave the final review and merge to you?

@TheoMcCabe TheoMcCabe mentioned this pull request Mar 20, 2024
@ATheorell ATheorell mentioned this pull request Mar 20, 2024
3 tasks
@ATheorell ATheorell merged commit 63d0a5e into main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants