Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_selector path as input path #704

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

lukaspetersson
Copy link
Contributor

To select files for improvement faster, the inital path of the file selector should be the input path.

This is especially important if using the CLI option as the printed tree can become very large otherwise.

@lukaspetersson lukaspetersson marked this pull request as ready for review September 16, 2023 17:40
@ATheorell
Copy link
Collaborator

Cannot judge whether there are any unforseen drawbacks of this. Input @pbharrin @UmerHA ?

@UmerHA
Copy link
Collaborator

UmerHA commented Sep 18, 2023

Cannot judge whether there are any unforseen drawbacks of this. Input @pbharrin @UmerHA ?

Hey, I don't see any drawback. Both changed functions (gui_file_selector and terminal_file_selector) still return a list of filenames, so it should be fine.

@ATheorell ATheorell merged commit 0d22c5e into gpt-engineer-org:main Sep 18, 2023
4 checks passed
@AntonOsika
Copy link
Collaborator

I like this.

Makes me think we should refactor the core logic and CLI UX specific things to make it easier to take decisions on what makes sense from UX perspective, and how the core building blocks should work.

@AntonOsika
Copy link
Collaborator

See #718, tagging @lukaspetersson for visibility

@lukaspetersson lukaspetersson deleted the selector_path branch September 22, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants