-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project path is now workspace #749
Conversation
@AntonOsika I think that this is a necessary and great change and it would be good to have it merged ASAP, since it is somewhat blocking progress in #721 . Since this is a rather big change to the structure with the designated workspace that I believe you designed, would it be possible for you to approve this? @UmerHA great job! Can you fix the failing tests? |
Finally found the time to look at this! I was testing the improve pipeline with this PR, using my favorite example (that you already know @UmerHA ) https://github.com/ATheorell/Opensource-Contribution-Leaderboard/tree/improveCode Either I'm using -improve wrong, or something is going wrong in the file selection. In the following, I'm on commit 4ac2990
On the main branch (c5ac0fc), it looks like this (the behavior I expect):
I'm also a little puzzled how, on the new branch, which .gpteng folder it is displaying, since I don't see it in the local repo. |
Hey some small changes requested, see my comments! |
Damn i made quite a simile PR this morning :) should have read this first!! perhaps i should close as this PR supercedes my work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, great job Umer.
I think we should leave the prompt as it was done previously (See my comment on main.py). Other than that LGTM.
I've addressed all review comments & the tests pass. Peter approved, Anton approved on Discord; so let's merge. |
Solves the question raised in #721:
The entire project folder is now the workspace. Everything else is moved into the
.gpteng
folder.This includes:
.gpteng
, then in the project path, then asked for viainput
all_output.txt
is moved into.gpteng/memory
With this, the
create project
andimprove project
workflows now assume the same workspace structure.