Fixing TypeError in file_selector.py #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated file_selector.py to handle WindowsPath objects by converting them to strings before joining. This resolves the TypeError encountered when trying to join WindowsPath objects directly.
Fix TypeError in file_selector.py
In the gpt-engineer project, a TypeError was encountered in file_selector.py when attempting to join WindowsPath objects directly. The error occurred as the code expected a string instance, but received a WindowsPath instance instead. To rectify this, the line of code was updated to convert WindowsPath objects to strings before joining. This change resolves the TypeError while maintaining the original functionality of the code, ensuring that the program can handle file paths correctly across different operating systems.
|
@Ruijian-Zha did you use the gui or cli selector? Both the functions def gui_file_selector(input_path: str) -> List[str]: def terminal_file_selector(input_path: str) -> List[str]: promise to return a string, which they didn't do in your case. It would be better if we solve the problem inside these functions so that they have the right return type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gpt-engineer project, a TypeError was encountered in file_selector.py when attempting to join WindowsPath objects directly. The error occurred as the code expected a string instance but received a WindowsPath instance instead. To rectify this, the line of code was updated to convert WindowsPath objects to strings before joining. This change resolves the TypeError while maintaining the original functionality of the code, ensuring that the program can handle file paths correctly across different operating systems.