Issue 718 refactor #766
Merged
Issue 718 refactor #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmerHA
approved these changes
Oct 5, 2023
gpt_engineer/cli/file_selector.py
Outdated
|
|
||
| from gpt_engineer.core.db import DB, DBs | ||
|
|
||
| # ... [rest of the code] ... |
| from gpt_engineer.cli.collect import collect_learnings | ||
| from gpt_engineer.core.db import DB, DBs, archive | ||
| from gpt_engineer.cli.learning import collect_consent | ||
| from gpt_engineer.core.steps import STEPS, Config as StepsConfig | ||
|
|
There was a problem hiding this comment.
i think we should order the imports
|
@captivus also, please fix the merge conflicts :) |
|
There is a hard coded path for starting the API in the failing workflow that needs to be updated (my bad). A better solution would probably be to install the API as an executable which is run. For now, maybe you can just update the path in the failing workflow. |
|
@captivus congrats on the merge - great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #718 and enhances documentation of each refactored module.
Tests running successfully on refactored codebase, with the exception of the misimplemented (missing) test for the AI module
