Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Platform support #16

Closed
wants to merge 5 commits into from
Closed

Add Android Platform support #16

wants to merge 5 commits into from

Conversation

aicodex
Copy link

@aicodex aicodex commented Aug 14, 2017

No description provided.

Copy link
Owner

@gpu gpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The native libraries should not be part of the repo. The repo is intended for the source code. They might be part of the release, either as the ZIP on jocl.org, or possibly here on GitHub

Copy link
Owner

@gpu gpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit difficult: I don't know which os.arch strings are out there. Of course, you know better which ones appear on android. But from what I can see, the original case of

if (osArch.startsWith("arm"))

is no longer covered now. Maybe it should be added again, to cover the case of "some" ARM architecture that is neither arm5tel nor armv7hl ....

@@ -51,17 +51,11 @@ if(ANDROID)
# mips, mips64
# }
# TODO: Support more than just "arm" in LibUtils
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO only refers to Android, right?

Copy link
Owner

@gpu gpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "empty" changes in the .java files (except for LibUtils, of course) are probably due to different line endings, right?

(It's a pity that GitHub does not seem to be able to show these differences in any way)

If so, it would be nice if the "not-changed" files could be omitted

@gpu
Copy link
Owner

gpu commented Aug 18, 2017

In doubt, I'd try to allocate some time (possibly next week) to apply the changes to the code and makefile locally, and create a ZIP from the resulting JAR, together with the native libraries, so that you can try out whether the result works on your system.

@aicodex
Copy link
Author

aicodex commented Aug 18, 2017

Oh I'd like to be the first person to try tomato. Ha Ha.

@gpu
Copy link
Owner

gpu commented Aug 18, 2017

Well, it will still contain your binaries and your changes, so it's your tomato ;-) I'd just like to avoid having the natives in the repo, and wanted to cover the "arm" case - that's really a point where changes are difficult to test (due to the many different arch types out there)

@gpu
Copy link
Owner

gpu commented Jun 15, 2022

I assume that JOCL essentially "works" on Android, as of #44 , and going to close this one.

@gpu gpu closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants