Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari support? #58

Closed
brianxautumn opened this issue Feb 25, 2017 · 7 comments
Closed

Safari support? #58

brianxautumn opened this issue Feb 25, 2017 · 7 comments
Labels
tbd v1

Comments

@brianxautumn
Copy link

When I try to run on safari I get:
WebGL: INVALID_ENUM: readPixels: invalid type
@fuzzie360
Copy link
Member

Thanks for the report.

The issue is Safari does not support readPixels with float type. There is already code to detect if the browser supports this, but it seems I have been broken recently. I will fix it soon.

robertleeplummerjr added a commit that referenced this issue Jul 21, 2017
@robertleeplummerjr
#58
d81271f 
Strict mode blows up on safari because jison has inline functions defined, this removes jison in favor of acorn
Yay! Less technical debt!
robertleeplummerjr added a commit that referenced this issue Jul 21, 2017
@robertleeplummerjr
#58
05bac5e 
Ensure acorn is a dev dependency
robertleeplummerjr added a commit that referenced this issue Jul 21, 2017
@robertleeplummerjr
#58
a27b03d 
Simpler isWebGl check, and remove cloning result right after we get it
robertleeplummerjr added a commit that referenced this issue Jul 21, 2017
@robertleeplummerjr
#58
3f04b30 
Simpler remove cloning result right after we get it in core, remove debugging in all tests
robertleeplummerjr added a commit that referenced this issue Jul 22, 2017
@robertleeplummerjr
#58
6b37206 
check null, not undefined
robertleeplummerjr added a commit that referenced this issue Jul 26, 2017
@robertleeplummerjr
More fixes for #58
31873d5
@robertleeplummerjr
Copy link
Member

Safari is supported, with the limitation of kernel maps.

@fuzzie360 fuzzie360 mentioned this issue Dec 18, 2017
Merged
@robertleeplummerjr
Copy link
Member

via: #234 (comment)

I don't think it should be fixed in this manner.

Reopening to try and find a quick fix for v1

@robertleeplummerjr
Copy link
Member

Let's get this resolved. Here is a quick and dirty possibility to skirt this issue #235

@robertleeplummerjr
Copy link
Member

The texture issue is resolved as of https://github.com/gpujs/gpu.js/releases/tag/1.0.0, however there is some sort of texture size issue that needs to be resolved before this can be closed.

@matpowel matpowel mentioned this issue Apr 27, 2018
Open
@robertleeplummerjr
Copy link
Member

Now supported, with limits, in v2 rc13.

@robertleeplummerjr
Copy link
Member

Even unit tests pass, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tbd v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fuzzie360 @robertleeplummerjr @brianxautumn