Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expectation values in webgpu:web_platform,external_texture,video:* #2042

Closed
shaoboyan opened this issue Dec 1, 2022 · 4 comments
Closed

Update expectation values in webgpu:web_platform,external_texture,video:* #2042

shaoboyan opened this issue Dec 1, 2022 · 4 comments
Assignees
@bjjones

Comments

@shaoboyan
Copy link
Contributor

Expectation values here https://github.com/gpuweb/cts/blob/main/src/webgpu/web_platform/external_texture/video.spec.ts#L40 is not accurate and need to be updated.
@shaoboyan
Copy link
Contributor Author

@bjjones Would you mind to take this? I could also help but I lack the original video content values.

blueboxd pushed a commit to blueboxd/dawn that referenced this issue Dec 1, 2022
@shaoboyan
Skip external_texture,video:* tests due to incorrect expectation values
b663db0 
Current expectation values in external_texture,video:* is not correct.
CTS issue 2042 (gpuweb/cts#2042) has been filed to fix it.
Skip these tests temporarily.

Bug: dawn:1082
Change-Id: Idaebe4f7e628a355adf6dd3db8f0ba2b35549e91
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/112500
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
@bjjones
Copy link
Contributor

bjjones commented Dec 1, 2022

Will do.

@bjjones bjjones self-assigned this Dec 1, 2022
@bjjones bjjones mentioned this issue Jan 5, 2023
Merged
7 tasks
@bjjones bjjones closed this as completed Jan 6, 2023
@bjjones
Copy link
Contributor

bjjones commented Jan 6, 2023

Re-opening the issue because we're still seeing minor variances between Chrome/Windows and Chrome/Mac OS. Ideally we'd have these producing the same value, but there could be issues related to the OSs handling colors differently. I'm thinking we may want to tolerate a small range of colors rather than an exact hex value in the test, but we should attempt to root cause issue on the Chromium side first.

@bjjones bjjones reopened this Jan 6, 2023
@bjjones
Copy link
Contributor

bjjones commented Jan 17, 2023

Resolving - previously reopened because our implementation was producing inconsistent results across platforms - it is now believed the Chromium implementation had an issue causing the difference.

@bjjones bjjones closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjjones bjjones

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaoboyan @bjjones