wgsl: Add countLeadingZeros tests
#1001
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,271 @@ | ||
| export const description = ` | ||
| Execution Tests for the 'countLeadingZeros' builtin function | ||
| `; | ||
|
|
||
| import { makeTestGroup } from '../../../../common/framework/test_group.js'; | ||
| import { GPUTest } from '../../../gpu_test.js'; | ||
| import { i32, i32Bits, TypeI32, u32, TypeU32, u32Bits } from '../../../util/conversion.js'; | ||
|
|
||
| import { Config, run } from './builtin.js'; | ||
|
|
||
| export const g = makeTestGroup(GPUTest); | ||
|
|
||
| g.test('integer_builtin_functions,countLeadingZeros_unsigned') | ||
| .uniqueId('xxxxxxxxxxxxxxxx') | ||
| .specURL('https://www.w3.org/TR/2021/WD-WGSL-20210929/#integer-builtin-functions') | ||
| .desc( | ||
| ` | ||
| countLeadingZeros: | ||
| T is i32, u32, vecN<i32>, or vecN<u32> countLeadingZeros(e: T) -> T | ||
|
|
||
| The number of consecutive 0 bits starting from the most significant bit of e, when T is a scalar type. | ||
| Component-wise when T is a vector. | ||
| Also known as "clz" in some languages. | ||
|
|
||
| Please read the following guidelines before contributing: | ||
| https://github.com/gpuweb/cts/blob/main/docs/plan_autogen.md | ||
| ` | ||
| ) | ||
| .params(u => | ||
| u | ||
| .combine('storageClass', ['uniform', 'storage_r', 'storage_rw'] as const) | ||
| .combine('vectorize', [undefined, 2, 3, 4] as const) | ||
| ) | ||
| .fn(async t => { | ||
| const cfg: Config = t.params; | ||
| run(t, 'countLeadingZeros', [TypeU32], TypeU32, cfg, [ | ||
| // Zero | ||
| { input: u32Bits(0b00000000000000000000000000000000), expected: u32(32) }, | ||
|
|
||
| // One | ||
| { input: u32Bits(0b00000000000000000000000000000001), expected: u32(31) }, | ||
|
|
||
| // 0's after leading 1 | ||
| { input: u32Bits(0b00000000000000000000000000000010), expected: u32(30) }, | ||
| { input: u32Bits(0b00000000000000000000000000000100), expected: u32(29) }, | ||
| { input: u32Bits(0b00000000000000000000000000001000), expected: u32(28) }, | ||
| { input: u32Bits(0b00000000000000000000000000010000), expected: u32(27) }, | ||
| { input: u32Bits(0b00000000000000000000000000100000), expected: u32(26) }, | ||
| { input: u32Bits(0b00000000000000000000000001000000), expected: u32(25) }, | ||
| { input: u32Bits(0b00000000000000000000000010000000), expected: u32(24) }, | ||
| { input: u32Bits(0b00000000000000000000000100000000), expected: u32(23) }, | ||
| { input: u32Bits(0b00000000000000000000001000000000), expected: u32(22) }, | ||
| { input: u32Bits(0b00000000000000000000010000000000), expected: u32(21) }, | ||
| { input: u32Bits(0b00000000000000000000100000000000), expected: u32(20) }, | ||
| { input: u32Bits(0b00000000000000000001000000000000), expected: u32(19) }, | ||
| { input: u32Bits(0b00000000000000000010000000000000), expected: u32(18) }, | ||
| { input: u32Bits(0b00000000000000000100000000000000), expected: u32(17) }, | ||
| { input: u32Bits(0b00000000000000001000000000000000), expected: u32(16) }, | ||
| { input: u32Bits(0b00000000000000010000000000000000), expected: u32(15) }, | ||
| { input: u32Bits(0b00000000000000100000000000000000), expected: u32(14) }, | ||
| { input: u32Bits(0b00000000000001000000000000000000), expected: u32(13) }, | ||
| { input: u32Bits(0b00000000000010000000000000000000), expected: u32(12) }, | ||
| { input: u32Bits(0b00000000000100000000000000000000), expected: u32(11) }, | ||
| { input: u32Bits(0b00000000001000000000000000000000), expected: u32(10) }, | ||
| { input: u32Bits(0b00000000010000000000000000000000), expected: u32(9) }, | ||
| { input: u32Bits(0b00000000100000000000000000000000), expected: u32(8) }, | ||
| { input: u32Bits(0b00000001000000000000000000000000), expected: u32(7) }, | ||
| { input: u32Bits(0b00000010000000000000000000000000), expected: u32(6) }, | ||
| { input: u32Bits(0b00000100000000000000000000000000), expected: u32(5) }, | ||
| { input: u32Bits(0b00001000000000000000000000000000), expected: u32(4) }, | ||
| { input: u32Bits(0b00010000000000000000000000000000), expected: u32(3) }, | ||
| { input: u32Bits(0b00100000000000000000000000000000), expected: u32(2) }, | ||
| { input: u32Bits(0b01000000000000000000000000000000), expected: u32(1) }, | ||
| { input: u32Bits(0b10000000000000000000000000000000), expected: u32(0) }, | ||
|
|
||
| // 1's after leading 1 | ||
| { input: u32Bits(0b00000000000000000000000000000011), expected: u32(30) }, | ||
| { input: u32Bits(0b00000000000000000000000000000111), expected: u32(29) }, | ||
| { input: u32Bits(0b00000000000000000000000000001111), expected: u32(28) }, | ||
| { input: u32Bits(0b00000000000000000000000000011111), expected: u32(27) }, | ||
| { input: u32Bits(0b00000000000000000000000000111111), expected: u32(26) }, | ||
| { input: u32Bits(0b00000000000000000000000001111111), expected: u32(25) }, | ||
| { input: u32Bits(0b00000000000000000000000011111111), expected: u32(24) }, | ||
| { input: u32Bits(0b00000000000000000000000111111111), expected: u32(23) }, | ||
| { input: u32Bits(0b00000000000000000000001111111111), expected: u32(22) }, | ||
| { input: u32Bits(0b00000000000000000000011111111111), expected: u32(21) }, | ||
| { input: u32Bits(0b00000000000000000000111111111111), expected: u32(20) }, | ||
| { input: u32Bits(0b00000000000000000001111111111111), expected: u32(19) }, | ||
| { input: u32Bits(0b00000000000000000011111111111111), expected: u32(18) }, | ||
| { input: u32Bits(0b00000000000000000111111111111111), expected: u32(17) }, | ||
| { input: u32Bits(0b00000000000000001111111111111111), expected: u32(16) }, | ||
| { input: u32Bits(0b00000000000000011111111111111111), expected: u32(15) }, | ||
| { input: u32Bits(0b00000000000000111111111111111111), expected: u32(14) }, | ||
| { input: u32Bits(0b00000000000001111111111111111111), expected: u32(13) }, | ||
| { input: u32Bits(0b00000000000011111111111111111111), expected: u32(12) }, | ||
| { input: u32Bits(0b00000000000111111111111111111111), expected: u32(11) }, | ||
| { input: u32Bits(0b00000000001111111111111111111111), expected: u32(10) }, | ||
| { input: u32Bits(0b00000000011111111111111111111111), expected: u32(9) }, | ||
| { input: u32Bits(0b00000000111111111111111111111111), expected: u32(8) }, | ||
| { input: u32Bits(0b00000001111111111111111111111111), expected: u32(7) }, | ||
| { input: u32Bits(0b00000011111111111111111111111111), expected: u32(6) }, | ||
| { input: u32Bits(0b00000111111111111111111111111111), expected: u32(5) }, | ||
| { input: u32Bits(0b00001111111111111111111111111111), expected: u32(4) }, | ||
| { input: u32Bits(0b00011111111111111111111111111111), expected: u32(3) }, | ||
| { input: u32Bits(0b00111111111111111111111111111111), expected: u32(2) }, | ||
| { input: u32Bits(0b01111111111111111111111111111111), expected: u32(1) }, | ||
| { input: u32Bits(0b11111111111111111111111111111111), expected: u32(0) }, | ||
|
|
||
| // random after leading 1 | ||
| { input: u32Bits(0b00000000000000000000000000000110), expected: u32(29) }, | ||
| { input: u32Bits(0b00000000000000000000000000001101), expected: u32(28) }, | ||
| { input: u32Bits(0b00000000000000000000000000011101), expected: u32(27) }, | ||
| { input: u32Bits(0b00000000000000000000000000111001), expected: u32(26) }, | ||
| { input: u32Bits(0b00000000000000000000000001101111), expected: u32(25) }, | ||
| { input: u32Bits(0b00000000000000000000000011111111), expected: u32(24) }, | ||
| { input: u32Bits(0b00000000000000000000000111101111), expected: u32(23) }, | ||
| { input: u32Bits(0b00000000000000000000001111111111), expected: u32(22) }, | ||
| { input: u32Bits(0b00000000000000000000011111110001), expected: u32(21) }, | ||
| { input: u32Bits(0b00000000000000000000111011011101), expected: u32(20) }, | ||
| { input: u32Bits(0b00000000000000000001101101111111), expected: u32(19) }, | ||
| { input: u32Bits(0b00000000000000000011111111011111), expected: u32(18) }, | ||
| { input: u32Bits(0b00000000000000000101111001110101), expected: u32(17) }, | ||
| { input: u32Bits(0b00000000000000001101111011110111), expected: u32(16) }, | ||
| { input: u32Bits(0b00000000000000011111111111110011), expected: u32(15) }, | ||
| { input: u32Bits(0b00000000000000111111111110111111), expected: u32(14) }, | ||
| { input: u32Bits(0b00000000000001111111011111111111), expected: u32(13) }, | ||
| { input: u32Bits(0b00000000000011111111111111111111), expected: u32(12) }, | ||
| { input: u32Bits(0b00000000000111110101011110111111), expected: u32(11) }, | ||
| { input: u32Bits(0b00000000001111101111111111110111), expected: u32(10) }, | ||
| { input: u32Bits(0b00000000011111111111010000101111), expected: u32(9) }, | ||
| { input: u32Bits(0b00000000111111111111001111111011), expected: u32(8) }, | ||
| { input: u32Bits(0b00000001111111011111101111111111), expected: u32(7) }, | ||
| { input: u32Bits(0b00000011101011111011110111111011), expected: u32(6) }, | ||
| { input: u32Bits(0b00000111111110111111111111111111), expected: u32(5) }, | ||
| { input: u32Bits(0b00001111000000011011011110111111), expected: u32(4) }, | ||
| { input: u32Bits(0b00011110101111011111111111111111), expected: u32(3) }, | ||
| { input: u32Bits(0b00110110111111100111111110111101), expected: u32(2) }, | ||
| { input: u32Bits(0b01010111111101111111011111011111), expected: u32(1) }, | ||
| { input: u32Bits(0b11100010011110101101101110101111), expected: u32(0) }, | ||
| ]); | ||
| }); | ||
|
|
||
| g.test('integer_builtin_functions,countLeadingZeros_signed') | ||
| .uniqueId('xxxxxxxxxxxxxxxx') | ||
| .specURL('https://www.w3.org/TR/2021/WD-WGSL-20210929/#integer-builtin-functions') | ||
|
There was a problem hiding this comment. |
||
| .desc( | ||
| ` | ||
| countLeadingZeros: | ||
| T is i32, u32, vecN<i32>, or vecN<u32> countLeadingZeros(e: T) -> T | ||
|
|
||
| The number of consecutive 0 bits starting from the most significant bit of e, when T is a scalar type. | ||
| Component-wise when T is a vector. | ||
| Also known as "clz" in some languages. | ||
|
|
||
| Please read the following guidelines before contributing: | ||
| https://github.com/gpuweb/cts/blob/main/docs/plan_autogen.md | ||
| ` | ||
| ) | ||
| .params(u => | ||
| u | ||
| .combine('storageClass', ['uniform', 'storage_r', 'storage_rw'] as const) | ||
| .combine('vectorize', [undefined, 2, 3, 4] as const) | ||
| ) | ||
| .fn(async t => { | ||
| const cfg: Config = t.params; | ||
| run(t, 'countLeadingZeros', [TypeI32], TypeI32, cfg, [ | ||
| // Zero | ||
| { input: i32Bits(0b00000000000000000000000000000000), expected: i32(32) }, | ||
|
|
||
| // One | ||
| { input: i32Bits(0b00000000000000000000000000000001), expected: i32(31) }, | ||
|
|
||
| // 0's after leading 1 | ||
| { input: i32Bits(0b00000000000000000000000000000010), expected: i32(30) }, | ||
| { input: i32Bits(0b00000000000000000000000000000100), expected: i32(29) }, | ||
| { input: i32Bits(0b00000000000000000000000000001000), expected: i32(28) }, | ||
| { input: i32Bits(0b00000000000000000000000000010000), expected: i32(27) }, | ||
| { input: i32Bits(0b00000000000000000000000000100000), expected: i32(26) }, | ||
| { input: i32Bits(0b00000000000000000000000001000000), expected: i32(25) }, | ||
| { input: i32Bits(0b00000000000000000000000010000000), expected: i32(24) }, | ||
| { input: i32Bits(0b00000000000000000000000100000000), expected: i32(23) }, | ||
| { input: i32Bits(0b00000000000000000000001000000000), expected: i32(22) }, | ||
| { input: i32Bits(0b00000000000000000000010000000000), expected: i32(21) }, | ||
| { input: i32Bits(0b00000000000000000000100000000000), expected: i32(20) }, | ||
| { input: i32Bits(0b00000000000000000001000000000000), expected: i32(19) }, | ||
| { input: i32Bits(0b00000000000000000010000000000000), expected: i32(18) }, | ||
| { input: i32Bits(0b00000000000000000100000000000000), expected: i32(17) }, | ||
| { input: i32Bits(0b00000000000000001000000000000000), expected: i32(16) }, | ||
| { input: i32Bits(0b00000000000000010000000000000000), expected: i32(15) }, | ||
| { input: i32Bits(0b00000000000000100000000000000000), expected: i32(14) }, | ||
| { input: i32Bits(0b00000000000001000000000000000000), expected: i32(13) }, | ||
| { input: i32Bits(0b00000000000010000000000000000000), expected: i32(12) }, | ||
| { input: i32Bits(0b00000000000100000000000000000000), expected: i32(11) }, | ||
| { input: i32Bits(0b00000000001000000000000000000000), expected: i32(10) }, | ||
| { input: i32Bits(0b00000000010000000000000000000000), expected: i32(9) }, | ||
| { input: i32Bits(0b00000000100000000000000000000000), expected: i32(8) }, | ||
| { input: i32Bits(0b00000001000000000000000000000000), expected: i32(7) }, | ||
| { input: i32Bits(0b00000010000000000000000000000000), expected: i32(6) }, | ||
| { input: i32Bits(0b00000100000000000000000000000000), expected: i32(5) }, | ||
| { input: i32Bits(0b00001000000000000000000000000000), expected: i32(4) }, | ||
| { input: i32Bits(0b00010000000000000000000000000000), expected: i32(3) }, | ||
| { input: i32Bits(0b00100000000000000000000000000000), expected: i32(2) }, | ||
| { input: i32Bits(0b01000000000000000000000000000000), expected: i32(1) }, | ||
| { input: i32Bits(0b10000000000000000000000000000000), expected: i32(0) }, | ||
|
|
||
| // 1's after leading 1 | ||
| { input: i32Bits(0b00000000000000000000000000000011), expected: i32(30) }, | ||
| { input: i32Bits(0b00000000000000000000000000000111), expected: i32(29) }, | ||
| { input: i32Bits(0b00000000000000000000000000001111), expected: i32(28) }, | ||
| { input: i32Bits(0b00000000000000000000000000011111), expected: i32(27) }, | ||
| { input: i32Bits(0b00000000000000000000000000111111), expected: i32(26) }, | ||
| { input: i32Bits(0b00000000000000000000000001111111), expected: i32(25) }, | ||
| { input: i32Bits(0b00000000000000000000000011111111), expected: i32(24) }, | ||
| { input: i32Bits(0b00000000000000000000000111111111), expected: i32(23) }, | ||
| { input: i32Bits(0b00000000000000000000001111111111), expected: i32(22) }, | ||
| { input: i32Bits(0b00000000000000000000011111111111), expected: i32(21) }, | ||
| { input: i32Bits(0b00000000000000000000111111111111), expected: i32(20) }, | ||
| { input: i32Bits(0b00000000000000000001111111111111), expected: i32(19) }, | ||
| { input: i32Bits(0b00000000000000000011111111111111), expected: i32(18) }, | ||
| { input: i32Bits(0b00000000000000000111111111111111), expected: i32(17) }, | ||
| { input: i32Bits(0b00000000000000001111111111111111), expected: i32(16) }, | ||
| { input: i32Bits(0b00000000000000011111111111111111), expected: i32(15) }, | ||
| { input: i32Bits(0b00000000000000111111111111111111), expected: i32(14) }, | ||
| { input: i32Bits(0b00000000000001111111111111111111), expected: i32(13) }, | ||
| { input: i32Bits(0b00000000000011111111111111111111), expected: i32(12) }, | ||
| { input: i32Bits(0b00000000000111111111111111111111), expected: i32(11) }, | ||
| { input: i32Bits(0b00000000001111111111111111111111), expected: i32(10) }, | ||
| { input: i32Bits(0b00000000011111111111111111111111), expected: i32(9) }, | ||
| { input: i32Bits(0b00000000111111111111111111111111), expected: i32(8) }, | ||
| { input: i32Bits(0b00000001111111111111111111111111), expected: i32(7) }, | ||
| { input: i32Bits(0b00000011111111111111111111111111), expected: i32(6) }, | ||
| { input: i32Bits(0b00000111111111111111111111111111), expected: i32(5) }, | ||
| { input: i32Bits(0b00001111111111111111111111111111), expected: i32(4) }, | ||
| { input: i32Bits(0b00011111111111111111111111111111), expected: i32(3) }, | ||
| { input: i32Bits(0b00111111111111111111111111111111), expected: i32(2) }, | ||
| { input: i32Bits(0b01111111111111111111111111111111), expected: i32(1) }, | ||
| { input: i32Bits(0b11111111111111111111111111111111), expected: i32(0) }, | ||
|
|
||
| // random after leading 1 | ||
| { input: i32Bits(0b00000000000000000000000000000110), expected: i32(29) }, | ||
| { input: i32Bits(0b00000000000000000000000000001101), expected: i32(28) }, | ||
| { input: i32Bits(0b00000000000000000000000000011101), expected: i32(27) }, | ||
| { input: i32Bits(0b00000000000000000000000000111001), expected: i32(26) }, | ||
| { input: i32Bits(0b00000000000000000000000001101111), expected: i32(25) }, | ||
| { input: i32Bits(0b00000000000000000000000011111111), expected: i32(24) }, | ||
| { input: i32Bits(0b00000000000000000000000111101111), expected: i32(23) }, | ||
| { input: i32Bits(0b00000000000000000000001111111111), expected: i32(22) }, | ||
| { input: i32Bits(0b00000000000000000000011111110001), expected: i32(21) }, | ||
| { input: i32Bits(0b00000000000000000000111011011101), expected: i32(20) }, | ||
| { input: i32Bits(0b00000000000000000001101101111111), expected: i32(19) }, | ||
| { input: i32Bits(0b00000000000000000011111111011111), expected: i32(18) }, | ||
| { input: i32Bits(0b00000000000000000101111001110101), expected: i32(17) }, | ||
| { input: i32Bits(0b00000000000000001101111011110111), expected: i32(16) }, | ||
| { input: i32Bits(0b00000000000000011111111111110011), expected: i32(15) }, | ||
| { input: i32Bits(0b00000000000000111111111110111111), expected: i32(14) }, | ||
| { input: i32Bits(0b00000000000001111111011111111111), expected: i32(13) }, | ||
| { input: i32Bits(0b00000000000011111111111111111111), expected: i32(12) }, | ||
| { input: i32Bits(0b00000000000111110101011110111111), expected: i32(11) }, | ||
| { input: i32Bits(0b00000000001111101111111111110111), expected: i32(10) }, | ||
| { input: i32Bits(0b00000000011111111111010000101111), expected: i32(9) }, | ||
| { input: i32Bits(0b00000000111111111111001111111011), expected: i32(8) }, | ||
| { input: i32Bits(0b00000001111111011111101111111111), expected: i32(7) }, | ||
| { input: i32Bits(0b00000011101011111011110111111011), expected: i32(6) }, | ||
| { input: i32Bits(0b00000111111110111111111111111111), expected: i32(5) }, | ||
| { input: i32Bits(0b00001111000000011011011110111111), expected: i32(4) }, | ||
| { input: i32Bits(0b00011110101111011111111111111111), expected: i32(3) }, | ||
| { input: i32Bits(0b00110110111111100111111110111101), expected: i32(2) }, | ||
| { input: i32Bits(0b01010111111101111111011111011111), expected: i32(1) }, | ||
| { input: i32Bits(0b11100010011110101101101110101111), expected: i32(0) }, | ||
| ]); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.specURL(https://www.w3.org/TR/2022/WD-WGSL-20220223/#integer-builtin-functions), since this doesn't exist in the older spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this matches the URL of all the other test plans, which will also need bulk updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example:
cts/src/webgpu/shader/execution/builtin/integer_built_in_functions.spec.ts
Line 10 in b30944b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel particularly strongly about this, since as you pointed out it matches the existing tests and likely needs a bulk update across the code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land these then, and I'll do a bulk update of all of these in a single atomic commit.