Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add firstTrailingBit tests #1003

Merged
merged 1 commit into from Feb 24, 2022

Conversation

ben-clayton
Copy link
Contributor

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (1144907):
Run tests | View tsdoc

@github-actions
Copy link

Previews, as seen when this build job started (8ea5dfe):
Run tests | View tsdoc

@ben-clayton ben-clayton marked this pull request as ready for review February 23, 2022 17:47
@ben-clayton ben-clayton merged commit 15e106b into gpuweb:main Feb 24, 2022
@ben-clayton ben-clayton deleted the firstTrailingBit branch February 24, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants