Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maxStorageBufferBindingSize limit #1163

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Add maxStorageBufferBindingSize limit #1163

merged 2 commits into from
Oct 23, 2020

Conversation

kvark
Copy link
Contributor

@kvark kvark commented Oct 21, 2020 •
edited by pr-preview bot

Kangz
Kangz reviewed Oct 21, 2020
View reviewed changes
spec/index.bs Outdated Show resolved Hide resolved
Kangz
Kangz reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@Kangz Kangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that the commit message mentions uniform instead of storage

@kvark kvark changed the title Add maxUniformBufferBindingSize limit Add maxStorageBufferBindingSize limit Oct 21, 2020
kainino0x
kainino0x approved these changes Oct 22, 2020
View reviewed changes
spec/index.bs Outdated Show resolved Hide resolved
@kvark @kainino0x
Update spec/index.bs
e209781 
Co-authored-by: Kai Ninomiya <kainino1@gmail.com>
@kvark kvark merged commit 13d58e9 into gpuweb:main Oct 23, 2020
@kvark kvark deleted the storage-size branch October 23, 2020 17:12
@kvark kvark mentioned this pull request Mar 1, 2021
Merged
bors bot added a commit to gfx-rs/wgpu that referenced this pull request Mar 2, 2021
@bors @kvark
Merge #1241
8a5668e 
1241: Update Extent3d::depth and Limits to latest upstream r=grovesNL a=kvark

**Connections**
- gpuweb/gpuweb#1390
- gpuweb/gpuweb#1328
- gpuweb/gpuweb#1163
- gpuweb/gpuweb#1274

**Description**
Just an API update up to spec.

**Testing**
Tested on wgpu-rs examples

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
@kainino0x kainino0x mentioned this pull request Jun 18, 2022
Closed
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
@Kangz
zero_init: add constant zero to prevent driver unrolling loops. (gpuw…
a676a5c 
…eb#1163)

The shader execution zero init tests produce large nested loops on
constant indices that are very tempting for drivers to unroll. This
commit prevents unrolling by adding zero to the loop bound using a zero
coming from a uniform buffer. This is not known to the shader compiler
which then can't optimize as much.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kangz Kangz Kangz left review comments

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kvark @Kangz @kainino0x