-
Notifications
You must be signed in to change notification settings - Fork 14
[WHLSL] Call arguments should be copied as soon as they are evaluated #41
Comments
At 2018-09-06T18:00:18Z, tdenney@apple.com wrote: |
At 2018-09-06T18:12:27Z, mmaxfield@apple.com wrote: View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review
I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code? |
At 2018-09-06T20:11:01Z, mmaxfield@apple.com wrote: View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review
Got it. Looks good. |
At 2018-09-06T20:36:49Z, commit-queue@webkit.org wrote: Clearing flags on attachment: 349045 Committed r235753: https://trac.webkit.org/changeset/235753 |
At 2018-09-06T20:36:50Z, commit-queue@webkit.org wrote: |
At 2018-09-06T20:40:26Z, webkit-bug-importer@group.apple.com wrote: |
Migrated from https://bugs.webkit.org/show_bug.cgi?id=189360:
At 2018-09-06T17:52:08Z, tdenney@apple.com wrote:
There is an observable bug in the interpreter whereby the shallow copy of values only occurred after all arguments to a call had been evaluated.
The text was updated successfully, but these errors were encountered: