Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fh is not transformed properly #35

Closed
ElliottMess opened this issue Dec 13, 2021 · 2 comments
Closed

fh is not transformed properly #35

ElliottMess opened this issue Dec 13, 2021 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ElliottMess
Copy link
Contributor

fh is not inverted by transform_uhc_data when it should be. This has no impact on calculations as calculate_uhc_billion inverts it before use.

For clarity in the code, the indicator should be inverted in transform_uhc_billion and calculate_uhc_billion should be modified.

@ElliottMess ElliottMess added the enhancement New feature or request label Dec 13, 2021
@ElliottMess ElliottMess added the bug Something isn't working label Jan 5, 2022
@ElliottMess
Copy link
Contributor Author

ElliottMess commented Jan 5, 2022

While investigating this issue, it was found that the absence of transformation of fh produced inacurate results since the introduction of the function to billionaire.

Indeed the calculation of UHC contribution to the billion work on transformed value. As fh was not transformed properly, the contribution were reversed. This had no impact on the dashboard as the fh contributions are not displayed and that the uhc_sm indicator was always calculated correctly.

pull requet #42 fixes the problem. Waiting for the integration of #38 and #40 to integrate into main.

@ElliottMess
Copy link
Contributor Author

Solved by #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant