Fix problem with fh transformation
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calculate_uhc_billion
…nto fh-transform # Conflicts: # data-raw/billions_examples.R
|
/style |
ElliottMess
force-pushed
the
main
branch
5 times, most recently
from
44f6042
to
10e59b2
Compare
added 4 commits
January 20, 2022 14:32
Merge branch 'main' into fh-transform # Conflicts: # .github/workflows/pr-commands.yaml # .gitignore # R/sysdata.rda # data-raw/billions_examples.R
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 37 37
Lines 3858 3858
=======================================
Hits 3242 3242
Misses 616 616
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/document
Fix problem identified in issue #35 where fh was not transformed in transform_uhc_data but in calculated_uhc_billion. This lead to an error in the calculations of the contributions of
fhto the billion: all contributions were reversed.Waiting for the approval of PR #38 and #40 to merge.
Once merged into main, the testing data frames will need to be recalculated and reuploaded to WHDH.