Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup timezone for GPX coordinates #91

Open
blackenstock opened this issue Nov 7, 2019 · 3 comments
Open

Lookup timezone for GPX coordinates #91

blackenstock opened this issue Nov 7, 2019 · 3 comments
Labels
enhancement hackergarten possible issues for Hackergarten events hacktoberfest possible issues for the Hacktoberfest

Comments

@blackenstock
Copy link

the shown time on the movie can be looked up using an api/library.

there is a list of solutions:
https://stackoverflow.com/questions/16086962/how-to-get-a-time-zone-from-a-location-using-latitude-and-longitude-coordinates

due to the fact a gpx file has lots of entries take care of take advantage of a library which is offline. it has to be checked if the timezone information is correctly taken. --> china has only one time zone which covers 5 time zones. so if at the same longitude more up north the solution has to lookup different time zone information.

@McPringle McPringle added enhancement hackergarten possible issues for Hackergarten events labels Nov 8, 2019
@n76
Copy link
Contributor

n76 commented Nov 10, 2019

The TimeShape java library linked to from the above stackoverflow sounds interesting. Apparently it would add about 1 second to the start up time of gpx-animator but since it runs off line it should be fast to run for individual lookups.

This might give the ability to look up the timezone for each point in the GPX file while rendering. That would mean that a track that crosses a timezone boundary will work pretty well, the displayed time properly showing the shift.

This might not be an issue for many/most as timezones are pretty big. But I can see a use for that near where I live.

@McPringle
Copy link
Collaborator

The initialization of the TimeShape library can be done before rendering. That will not affect the startup time and we'll able to initialize it with the bounding box of the loaded GPX file to reduce memory footprint. This initialization can be done asynchronously while GPX Animator is reading the map tiles. That would not affect the speed at all. At least not recognizable.

That library sounds very interesting. I like that idea, we should do that! :-)

@McPringle
Copy link
Collaborator

I'll target it for the 2.0 release. If you (or someone else) starts working on it, please create a branch. And comment here, so others know, that someone is working on it.

@McPringle McPringle added this to the v2.0 milestone Nov 10, 2019
@McPringle McPringle changed the title lookup timezone information from coordinates of gpx file Lookup timezone for GPX coordinates Nov 10, 2019
@McPringle McPringle modified the milestones: v2.0, v1.5 Dec 6, 2019
@McPringle McPringle pinned this issue Dec 24, 2019
@McPringle McPringle modified the milestones: v1.5, v1.6 Mar 5, 2020
@McPringle McPringle added the hacktoberfest possible issues for the Hacktoberfest label Oct 15, 2020
@McPringle McPringle removed this from the v1.6 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hackergarten possible issues for Hackergarten events hacktoberfest possible issues for the Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants