Fix stream cancelling for FetchPolicy.CacheAndNetwork, too #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 11, 2020 14:57
…ing a await for / yield loop and make the method synchronous. partial fix for gql-dart#51
|
Thanks for the PR! I remember there was a reason we used async await for the network request, but I'm travelling now and can't dig into it. I'll try to take another look next week. |
smkhalsa
reviewed
Aug 18, 2020
smkhalsa
requested changes
Aug 18, 2020
smkhalsa
reviewed
Aug 18, 2020
added 3 commits
August 19, 2020 12:34
…am. change test that verifies behaviour when link throws an exception
smkhalsa
reviewed
Aug 19, 2020
There was a problem hiding this comment.
I'd like to further investigate the FetchPolicy.CacheAndNetwork code at some point to better understand what's going on, but I think these changes are fine for now. There may be a way to refactor that doesn't require the use of shareValue at all.
Thanks again for the PR!
ferry/test/error_test.dart
Outdated
| } | ||
|
|
||
| abstract class Mockable { |
There was a problem hiding this comment.
Did you intend to leave the Mockable & MyMock classes in here?
There was a problem hiding this comment.
Ah, my bad. Of course not.
added 2 commits
August 19, 2020 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #51 .
This includes the changes in #52, and fixes for
FetchPolicy.cacheAndNetworkpolicy, and extends the test for canceling the streams when they are not listened to anymore for all FetchPolicies.I am not really sure why these fixes to
FetchPolicy.cacheAndNetworkare necessary, I know too little about rxdart for this. But with wrapping the network stream in a new StreamController and manually canceling it, the canceling of the stream is passed on the Link, too.There might be a better with rxdart, which is why I put this fix in a separate PR.