Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gql_link] exceptions #115

Closed
agent3bood opened this issue Jun 4, 2020 · 1 comment
Closed

[gql_link] exceptions #115

agent3bood opened this issue Jun 4, 2020 · 1 comment

Comments

@agent3bood
Copy link
Collaborator

I am working on adding exceptions to WebSocketLink, the plan is

  1. WebSocketLinkParserException Exception occurring when parsing fails or parsed response is missing both data and errors.

  2. WebSocketLinkServerException Exception occurring when network fails.

Right now the error "parsed response is missing both data and errors." is handled as ServerException

I want to refactor this as ResponseFormatException.

Any suggestions, should I continue as planned?
@agent3bood agent3bood mentioned this issue Jun 6, 2020
Closed
@agent3bood
Copy link
Collaborator Author

Code review and comments are welcome, I will write tests once we agree on this.

@agent3bood agent3bood mentioned this issue Aug 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agent3bood