Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] websocket link exceptions #116

Closed
wants to merge 2 commits into from
Closed

[WIP] websocket link exceptions #116

wants to merge 2 commits into from

Conversation

agent3bood
Copy link
Collaborator

@klavs
Copy link
Contributor

klavs commented Jul 9, 2020

@agent3bood sorry for the very late response, but thanks for your contributions.

Could you please describe why this involves changes to gql_http_link?

@agent3bood
Copy link
Collaborator Author

agent3bood commented Jul 9, 2020 •
edited
Loading

gql_http_link will throw HttpLinkServerException when

parsed response is missing both data and errors

I think when data and errors are missing it should throw HttpLinkParserException.

What is your opinion on this? @klavs

@agent3bood
Copy link
Collaborator Author

Closed in favor of #130

@agent3bood agent3bood closed this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agent3bood @klavs