Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gql_http_link] Add response headers to context #119

Closed
micimize opened this issue Jun 15, 2020 · 3 comments
Closed

[gql_http_link] Add response headers to context #119

micimize opened this issue Jun 15, 2020 · 3 comments

Comments

@micimize
Copy link
Contributor

In graphql-flutter I closed an issue about a specific solution for accessing response headers a while ago, but never followed up with the correct solution (adding headers to context)

zino-hofmann/graphql-flutter#371

@joshuadeguzman
Copy link

Hey @micimize,

I am using cookies for authenticating my requests. I found a workaround) at least for now for achieving it.

Curious about your thoughts in terms of performance passing a custom http client.

Thank you!

@micimize
Copy link
Contributor Author

@joshuadeguzman any performance hit would be due to the overall performance diff between dio and http, which I would expect to be at most negligible. Also http also has some serious long-standing open issues that do not inspire confidence

@jeffscaturro-aka
Copy link

jeffscaturro-aka commented Aug 21, 2020

Cross-posting the tl;dr of zino-hofmann/graphql-flutter#704 (comment) here for more visibility and a reminder: we stuff the raw response object into the context that we can extract from a custom link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants