-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gql_http_link] Add response headers to context #121
Conversation
Staying up to date
@@ -1,3 +1,7 @@ | |||
## 0.2.10 | |||
|
|||
- add `headers` to `HttpLinkResponseContext` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that this should be included on a release commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean, should I remove this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is we update the changelog in the change PR, so this is right. @klavs seems we should probably make a more detailed contributor doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the assert
@@ -1,3 +1,7 @@ | |||
## 0.2.10 | |||
|
|||
- add `headers` to `HttpLinkResponseContext` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is we update the changelog in the change PR, so this is right. @klavs seems we should probably make a more detailed contributor doc.
@agent3bood it LGTM so yeah it's just waiting on @klavs |
@micimize, agreed. I'm not in favor of the Angular-style commit messages. That's been a major blocker for me offering small fixes to projects like graphql_flutter. I never liked spending more time reading the policies than coding the fix. I prefer being open to "free-style" contributions with automatic checks (as much as that is possible) |
Related issue #119