Allow mutation and subscription operations #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@klavs can we merge this? |
klavs
suggested changes
Feb 4, 2020
| OperationDefinitionNode op, [ | ||
| Map<OperationType, String> rootTypes = defaultRootTypes, | ||
| ]) => | ||
| schema.definitions |
There was a problem hiding this comment.
You are looking for a ObjectTypeDefinitionNode by name and then returning the name.
So, you can just return the name immediately without iteration.
There was a problem hiding this comment.
😳you're right.
I've updated it and added support for a custom schema definition.
smkhalsa
force-pushed
the
operation-types
branch
from
0c00314
to
e6f4dad
Compare
klavs
reviewed
Feb 4, 2020
klavs
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #40, this PR maps the operation to the appropriate type.