Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rx_fft: normalize fft windows #1190

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

vladisslav2011
Copy link
Contributor

Always show correct signal magnitude on the panadapter independent of selected FFT window type.

Panadapter levels with this fix applied
rectangular-fixed
hamming-fixed
flattop-fixed

Fix #1189

Always show correct signal magnitude on the panadapter independent of
selected FFT window type.
@argilo
Copy link
Member

argilo commented Feb 11, 2023

This seems like a good idea.

It looks like the build function has a normalize argument: https://www.gnuradio.org/doc/doxygen/classgr_1_1fft_1_1window.html#a6b4f09baa6c2a7d576dd58ec4ab3f939

Could we use that instead?

@vladisslav2011
Copy link
Contributor Author

Could we use that instead?

normalize is 3.9+, so not now. Maybe later.

@argilo
Copy link
Member

argilo commented Feb 18, 2023

normalize is 3.9+, so not now. Maybe later.

I guess we can't use it at all, because it's for energy normalization. That's fine.

@argilo
Copy link
Member

argilo commented Feb 18, 2023

I tested this and it works well. CW peaks now show the correct amplitude regardless of the window.

The amplitude of wideband signals (like the noise floor) varies between window functions because we've chosen to normalize amplitude instead of energy, but I think that's fine.

@argilo argilo merged commit f04d6a1 into gqrx-sdr:master Feb 18, 2023
@argilo argilo added the feature label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panadapter displays wrong CW signal level when other, than rectangular window is selected
2 participants