Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that a minimum filter width is maintained #825

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

argilo
Copy link
Member

@argilo argilo commented Oct 1, 2020

When dragging the "Low cut" and "High cut" frequencies in the plotter, it is easy to accidentally drag the high cut frequency below the low cut frequency (or vice versa), which causes the receive flowgraph to crash:

sched: <block fir_filter_blk<IN_T,OUT_T,TAP_T> (14)> is requesting more input data
  than we can provide.
  ninput_items_required = 11570
  max_possible_items_available = 8191
  If this is a filter, consider reducing the number of taps.

To recover from this situation, it is necessary to correct the filter frequencies, then stop & restart the DSP.

To avoid this problem I've added bounds checks to ensure that the two frequencies always remain at least 200 Hz apart. This matches the minimum bandwidth of the CW demodulator.

@argilo
Copy link
Member Author

argilo commented Oct 1, 2020

@Flamewires This fixes the bug you encountered during GRCon.

@Flamewires
Copy link

Awesome, I completely forget about this, thanks for remembering and fixing it!

@csete csete merged commit b7379b3 into gqrx-sdr:master Oct 3, 2020
@csete
Copy link
Collaborator

csete commented Oct 3, 2020

Thanks!. Indeed, this has often been a problem when using narrow-band modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants