fix(package/gqty): remove alias without args (#1476)

gqty-dev · Feb 1, 2023 · 595ec84 · 595ec84 · vercel · Feb 1, 2023
1 parent 67553c2
commit 595ec84
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/.changeset/sour-rocks-vanish.md b/.changeset/sour-rocks-vanish.md
@@ -0,0 +1,5 @@
+---
+'gqty': patch
+---
+
+Remove alias without args
diff --git a/packages/gqty/src/Accessor/index.ts b/packages/gqty/src/Accessor/index.ts
@@ -11,6 +11,7 @@ import {
 import { Selection, SelectionType } from '../Selection';
 import {
   decycle,
+  isEmptyObject,
   isInteger,
   isObject,
   isObjectWithType,
@@ -207,6 +208,8 @@ export function createAccessorCreators<
         });
       }
 
+      const args = dataOrArgs as Record<string, unknown>;
+
       const resolveInfo = (
         accessorOrSelection as Function & {
           [ResolveInfoSymbol]?: ResolveInfo;
@@ -221,7 +224,7 @@ export function createAccessorCreators<
 
       const selection = innerState.selectionManager.getSelection({
         ...resolveInfo,
-        args: dataOrArgs as Record<string, unknown>,
+        args: isEmptyObject(args) ? undefined : args,
       });
 
       const data = extractDataFromProxy(possibleData);
@@ -598,7 +601,7 @@ export function createAccessorCreators<
             let { pureType, isArray } = parseSchemaType(__type);
 
             const resolve = (args?: {
-              argValues: Record<string, unknown>;
+              argValues?: Record<string, unknown>;
               argTypes: Record<string, string>;
             }): unknown => {
               const selection = innerState.selectionManager.getSelection({
@@ -696,9 +699,7 @@ export function createAccessorCreators<
               };
 
               return Object.assign(
-                function ProxyFn(
-                  argValues: Record<string, unknown> = emptyVariablesObject
-                ) {
+                function ProxyFn(argValues?: Record<string, unknown>) {
                   return resolve({
                     argValues,
                     argTypes: __args,
@@ -715,6 +716,7 @@ export function createAccessorCreators<
         });
       }
     );
+
     return accessor;
   }
 
@@ -794,5 +796,3 @@ export function createAccessorCreators<
     subscription,
   };
 }
-
-const emptyVariablesObject = {};
diff --git a/packages/gqty/test/accessor.test.ts b/packages/gqty/test/accessor.test.ts
@@ -398,13 +398,7 @@ describe('mutate accessors', () => {
   test('works', async () => {
     const { query, setCache, resolved } = await createTestClient();
 
-    setCache(
-      query.human,
-      {},
-      {
-        name: 'hello',
-      }
-    );
+    setCache(query.human, {}, { name: 'hello' });
 
     const humanHello = query.human();