Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hapi@13.5.0 breaks build 🚨 #22

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

hapi just published its new version 13.5.0.

State Failing tests 🚨
Dependency hapi
New version 13.5.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As hapi is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 10 commits .

  • 22825a1 13.5.0
  • 8ce9b40 Remove script
  • 8e2a594 npm3
  • a15944d Cleanup for #3178
  • 25db02a Merge pull request #3178 from kanongil/catch-errors-fix
  • 78e50de Merge pull request #3174 from nrotta/master
  • 9d8d617 no cache override. Closes #3206
  • 5e98494 Move try/catch logic to separate function
  • 6f81b6a Handle thrown errors from res.setHeader and res.writeHead
  • b7dbd2a Fixes #3155 - Calling reply without a payload on a JSONP route throws an error

See the full diff.

@gr2m
Copy link
Owner

gr2m commented Jul 6, 2016

false positive

@gr2m gr2m closed this Jul 6, 2016
@gr2m gr2m deleted the greenkeeper-hapi-13.5.0 branch July 29, 2016 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants